Fix/character prefs not loading#261
Open
BartDrown wants to merge 3 commits intoMonkestation:masterfrom
Open
Conversation
flleeppyy
requested changes
Feb 25, 2026
code/modules/client/preferences.dm
Outdated
|
|
||
|
|
||
| character.update_body(0) | ||
| character.force_update_limbs() |
Member
There was a problem hiding this comment.
do not move this. please move it back. it was part of my mannequin optimization pr.
Author
There was a problem hiding this comment.
Sure thing.
How about iterating over organs and using sync_colour_to_human?
Would that also be too costly?
Probably I could fake fix it with slot reload or some additional flag, but I guess that would add up to complexity.
Author
There was a problem hiding this comment.
nvm, I'm dumb, I should just rebuild organs on new skintone with existing flag
Author
There was a problem hiding this comment.
Fixed that, also updated max skin tone darkness to 225, to be consistent with description
…hange rebuild_organs, adjust max tone settings to reflect description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR attempts to fix character preferences/setup on both Linux and Windows.
This code should clear all handles to files preventing file lock state on Linux.
Additionaly, slots were not correctly loaded due to bug with determining which character prefs version is used, in which case system always attempted to load old prefs, despite new being available.
This PR additionally fixes skin tone issue. Skin tone after change in character setup UI wasn't properly displayed if not save explicitly to slot and reloaded.
Why It's Good For The Game
If those changes work, they should fix issue with no player prefs being saved/loaded on live server.
Testing
Those changes would require not-so extensive testing, but at least sanity checkup on live server, before actual launch, to avoid potential issues or data corruption.
My local tests went good, slots are saved, pesistent across multiple instance launches, skin tone changes after changing in UI, no lock state happening (though I'm testing it on Windows, so it might not be the same for live server working on Linux)
Changelog
🆑
fix: character preferences not saving due to file lock
fix: character prefs not loading
fix: skin tone not changing in character setup menu
/:cl: